Skip to content

Emit used-before-assignment when calling nested functions before assignment #6959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2022
Merged

Emit used-before-assignment when calling nested functions before assignment #6959

merged 2 commits into from
Jun 16, 2022

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Jun 15, 2022 •
edited
Loading

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #6812

@jacobtylerwalls jacobtylerwalls added False Negative 🦋 No message is emitted but something is wrong with the code C: used-before-assignment Issues related to 'used-before-assignment' check labels Jun 15, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.15.0 milestone Jun 15, 2022
@coveralls
Copy link

coveralls commented Jun 15, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2505739769

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0005%) to 95.546%
Totals Coverage Status
Change from base Build 2505734471: 0.0005%
Covered Lines: 16431
Relevant Lines: 17197
💛 - Coveralls

@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit de3d448

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !

@jacobtylerwalls jacobtylerwalls merged commit b0a3521 into pylint-dev:main Jun 16, 2022
@jacobtylerwalls jacobtylerwalls deleted the nested-func-before branch June 16, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
C: used-before-assignment Issues related to 'used-before-assignment' check False Negative 🦋 No message is emitted but something is wrong with the code
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

No used-before-assignment for use of nested function before its definition
3 participants
@jacobtylerwalls @coveralls @Pierre-Sassoulas