test_run_pylint_config: ignore pytest args

[AdamWill]

Type of Changes

	Type
✓	🐛 Bug fix

Description

This test fails if run through pytest with any args, because
_run_pylint_config passes through args from the command line
without checking if the args are actually intended for
pylint-config. We have to pass it some fake args that evaluate
truth-y but don't break anything, to avoid this.

Signed-off-by: Adam Williamson [email protected]

[AdamWill]

Didn't add a changelog entry as the change is only to a test. To see the problem here, just try:

pytest -v tests/config/pylint_config/test_run_pylint_config.py

and watch it fail because pylint-config tries to handle the filename arg and gives unexpected output (_run_pylint_config passes through args starting from the second one, so we hit the bug if there's more than one arg). With this change, the test passes no matter what args you give pytest.

[AdamWill]

I guess technically it might be better to change _run_pylint_config somehow, but as it's only used in two ways - in this test, and as the entry point for the pylint-config command - I don't think it's really necessary?

[coveralls]

Pull Request Test Coverage Report for Build 2652920634

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 95.4%

---

Totals
Change from base Build 2650762732:	0.0%
Covered Lines:	16778
Relevant Lines:	17587

---

💛 - Coveralls

[jacobtylerwalls]

Brilliant, I saw this from time to time but never found the energy to look into it.

[Pierre-Sassoulas]

This bothered me for months literally. Test worked as a standalone but not when launching everything and I thought there was a lot of work to fix it. Great job!

[DanielNoord]

Worked on my machine 😅

Thanks for fixing!