Use trace not turtle in import_outside_toplevel test #7168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream (e.g. in Fedora) tkinter and turtle aren't always included in the core Python package in order to avoid pulling in a lot of graphical dependencies on systems that do not need them. It doesn't really matter what libs are used in this test, so let's replace it with trace. Signed-off-by: Adam Williamson <[email protected]>
|
The Fedora package had the test disabled because of this failure (I guess the maintainer hadn't realized why the test was failing). We could just pull in our python-tkinter package as a build dependency, but I figured this was just as easy and doesn't bloat our build dependencies... |
jacobtylerwalls
added
the
Skip news 🔇
Pull Request Test Coverage Report for Build 2653368616
💛 - Coveralls |
jacobtylerwalls
approved these changes
Jul 12, 2022
Pierre-Sassoulas
approved these changes
Jul 12, 2022
DanielNoord
approved these changes
Jul 12, 2022
|
Yeah, I'm hoping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Downstream (e.g. in Fedora) tkinter and turtle aren't always
included in the core Python package in order to avoid pulling in
a lot of graphical dependencies on systems that do not need them.
It doesn't really matter what libs are used in this test, so
let's replace it with trace.