Skip to content

Check for contextlib.suppress in node_ignores_exception #7327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
🐛 Bug fix

Description

Closes #7270.

Sorry, something went wrong.

@DanielNoord DanielNoord added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Aug 21, 2022
@DanielNoord DanielNoord added this to the 2.15.0 milestone Aug 21, 2022
@coveralls
Copy link

coveralls commented Aug 21, 2022

Pull Request Test Coverage Report for Build 2898563473

  • 29 of 29 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 95.261%

Totals Coverage Status
Change from base Build 2897313644: 0.007%
Covered Lines: 16907
Relevant Lines: 17748

💛 - Coveralls

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit a029947

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielNoord DanielNoord merged commit e2816cd into pylint-dev:main Aug 22, 2022
@DanielNoord DanielNoord deleted the import-error branch August 22, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import-error inconsistency between except ImportError and with contextlib.suppress(ImportError)
3 participants