Skip to content

Cleanup test skips #9773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Cleanup test skips #9773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
921de90
Remove test skips for 3.7
jacobtylerwalls Jul 7, 2024
18a82ad
Fix max_pyver in two tests for 3.8
jacobtylerwalls Jul 7, 2024
9e6e529
Remove test skips for 3.7
jacobtylerwalls Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tests/checkers/unittest_non_ascii_name.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

from __future__ import annotations

import sys
from collections.abc import Iterable

import astroid
Expand All @@ -20,9 +19,6 @@ class TestNonAsciiChecker(pylint.testutils.CheckerTestCase):
CHECKER_CLASS = pylint.checkers.non_ascii_names.NonAsciiNameChecker
checker: pylint.checkers.non_ascii_names.NonAsciiNameChecker

@pytest.mark.skipif(
sys.version_info < (3, 8), reason="requires python3.8 or higher"
)
def test_kwargs_and_position_only(self) -> None:
"""Even the new position only and keyword only should be found."""
node = astroid.extract_node(
Expand Down
50 changes: 0 additions & 50 deletions tests/functional/d/deprecated/deprecated_methods_py3.py
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tests/functional/d/deprecated/deprecated_methods_py3.rc
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions tests/functional/d/deprecated/deprecated_methods_py3.txt
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion tests/functional/u/unnecessary/unnecessary_dunder_call_py38.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[testoptions]
max_pyver=3.8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in #9034, but I think the idea was to run this test on 3.8, not skip it on 3.8.

max_pyver is actually pretty confusingly named.

max_pyver=3.9
except_implementations=PyPy
2 changes: 1 addition & 1 deletion tests/functional/u/unnecessary/unnecessary_dunder_call_py38_pypy.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[testoptions]
max_pyver=3.8
max_pyver=3.9
except_implementations=CPython
2 changes: 0 additions & 2 deletions tests/pyreverse/test_diadefs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

from __future__ import annotations

import sys
from collections.abc import Iterator
from pathlib import Path

Expand Down Expand Up @@ -248,7 +247,6 @@ def test_known_values4(HANDLER: DiadefsHandler, PROJECT: Project) -> None:
]


@pytest.mark.skipif(sys.version_info < (3, 8), reason="Requires dataclasses")
def test_regression_dataclasses_inference(
HANDLER: DiadefsHandler, get_project: GetProjectCallable
) -> None:
Expand Down
Loading