-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Revert "Remove --min_pyver_end_position
"
#9784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove --min_pyver_end_position
"
#9784
Conversation
This reverts commit 4b45192.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9784 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 174 174
Lines 18860 18870 +10
=======================================
+ Hits 18070 18080 +10
Misses 790 790
|
This comment has been minimized.
This comment has been minimized.
Hmm shouldn't there be a place where it's used too ? |
This was the reason why I approved the removal. If we really need it this is trivial to add again but for now there doesn't seem to be a reason to have it in the codebase. |
This reverts commit 833762f.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Jacob !
pylint/testutils/output_line.py
Outdated
@@ -58,8 +62,19 @@ def _get_column(column: str | int) -> int: | |||
"""Handle column numbers.""" | |||
return int(column) | |||
|
|||
@staticmethod | |||
def _get_py38_none_value(value: _T, check_endline: bool) -> _T | None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def _get_py38_none_value(value: _T, check_endline: bool) -> _T | None: | |
def _get_end_line_and_end_col(value: _T, check_endline: bool) -> _T | None: |
pylint/testutils/output_line.py
Outdated
end_line = cls._value_to_optional_int(row[3]) | ||
end_column = cls._value_to_optional_int(row[4]) | ||
end_line = cls._value_to_optional_int( | ||
cls._get_py38_none_value(row[3], check_endline) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cls._get_py38_none_value(row[3], check_endline) | |
cls._get_end_line_and_end_col(row[3], check_endline) |
pylint/testutils/output_line.py
Outdated
cls._get_py38_none_value(row[3], check_endline) | ||
) | ||
end_column = cls._value_to_optional_int( | ||
cls._get_py38_none_value(row[4], check_endline) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cls._get_py38_none_value(row[4], check_endline) | |
cls._get_end_line_and_end_col(row[4], check_endline) |
This reverts commit 4b45192 and 833762f..
See #9774 (comment).