add PylonBlock waila fallback to name#139
Merged
Merged
Conversation
LordIdra
requested changes
Jun 15, 2025
Seggan
reviewed
Jun 15, 2025
Contributor
Author
|
Okay, this actually works now, the pylon block Component.translatable passes an alternative key as a fallback and the AddonTranslator.translate checks for fallback if translated is null, if it's still null the whole function returns null like before.
|
Seggan
reviewed
Jun 25, 2025
…ddonTranslator.kt Co-authored-by: Seggan <seggan21@gmail.com>
…llow lore to fallback to empty string
Seggan
approved these changes
Jun 26, 2025
LordIdra
approved these changes
Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces duplicate translation values where names were the same as waila