Skip to content

Restore faith in CI#160

Merged
LordIdra merged 2 commits into
masterfrom
restore-faith-in-ci
Jul 5, 2025
Merged

Restore faith in CI#160
LordIdra merged 2 commits into
masterfrom
restore-faith-in-ci

Conversation

@LordIdra

@LordIdra LordIdra commented Jul 3, 2025

Copy link
Copy Markdown
Contributor
  • Fix unregister not being called on main thread in a test
  • Deletes the fluid loop test. I investigated this in-game myself and discovered that loop behaviour is non-deterministic by nature of the implementation. Taking fluids from machines is done on a first-come-first-serve basis - so if your producer is producing enough to saturate the loop, it may be that one of the blocks in the loop just takes all its fluid from the producer and none from the second block. Yeah it's unintuitive but probably not worth the time and performance hit to fix

closes #159

@LordIdra
LordIdra requested a review from Seggan July 3, 2025 21:06

@OhmV-IR OhmV-IR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LordIdra
LordIdra merged commit ebe6fdd into master Jul 5, 2025
3 checks passed
@LordIdra
LordIdra deleted the restore-faith-in-ci branch July 5, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix FluidTickerLoopTest

3 participants