Skip to content

Separate story text from lore and allow disabling story text#845

Merged
LordIdra merged 3 commits into
masterfrom
idra/story-text-changes
Jun 16, 2026
Merged

Separate story text from lore and allow disabling story text#845
LordIdra merged 3 commits into
masterfrom
idra/story-text-changes

Conversation

@LordIdra

@LordIdra LordIdra commented Jun 14, 2026

Copy link
Copy Markdown
Contributor
  • Separates story text from lore by adding a story key for items (see Separate story text from lore and allow disabling story text pylon#1065)
  • Updates translator to only add story text if player has it enabled and locale has the story text available
  • Moves guide player settings into main player settings page object (I think this makes sense but not sure, any other input?)

@LordIdra

Copy link
Copy Markdown
Contributor Author

closes #790

@JustAHuman-xD JustAHuman-xD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but untested

@LordIdra
LordIdra merged commit d621e08 into master Jun 16, 2026
3 checks passed
@LordIdra
LordIdra deleted the idra/story-text-changes branch June 16, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants