Skip to content

Conversation

@aloctavodia
Copy link
Member

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the extra files with .md instead of .myst.md extension it looks good

@fonnesbeck
Copy link
Member

arviz.preview? Do we want to wait on this until its no longer in preview? We will just have to go back and change this again, right?

@aloctavodia
Copy link
Member Author

aloctavodia commented Dec 3, 2025

I think we should not wait. Once we have ArviZ 1.0, we will need to update one import. I will do the update.

Edit:
@fonnesbeck, not sure my previous answer was that useful. My main motivation with this PR is to check that "new arviz" has all the functions that we want and they work as expected, and that others can provide feedback. I think is Ok to merge this eventually, but fine with me if we want to wait for ArviZ 1.0 (or RC).

@OriolAbril
Copy link
Member

OriolAbril commented Dec 3, 2025

I think it is probably better to start the migration before the actual 1.0 release. After that we'll only need to replace arviz.preview by arviz. I think it will also help signal users they should start preparing for the migration which will make the update smoother.

Moreover, if we wait, we won't be able to update any page until pymc has fully migrated internally. That means there are many new features like dedicated ppc plots, prior sensitivity checks, loo with moment matching or subsampling, advanced facetting and aesthetic mappings that are ready to use but can't be used because we don't want to use arviz.preview.

@fonnesbeck
Copy link
Member

That sounds good to me.

@aloctavodia just a few failures that I would have expected the pre-commit hooks to have caught.

@aloctavodia
Copy link
Member Author

The failures I omitted are related to links, not sure about the correct syntax.

@OriolAbril
Copy link
Member

I think the change I did will fix pre-commit (once I guess the right escaping rules). We were disallowing any links to arviz.github.io because old arviz docs where at arviz.github.io/arviz and we wanted to use sphinx cross-references instead, https://arviz-devs.github.io/EABM/ is also under the same root URL but it is a quarto website so we can't use the same cross-references trivially

@OriolAbril
Copy link
Member

the new error related to pyupgrade seems to be happening on main too. No idea about the potential cause without properly looking into it. The logs from the failed run in main might be more helpful that the ones in the PR though: https://github.com/pymc-devs/pymc-examples/actions/runs/20341400571/job/58441502049. It mentions "syntaxwarnings that will become errors"

@aloctavodia aloctavodia merged commit 1e9b421 into main Jan 1, 2026
2 checks passed
@aloctavodia aloctavodia deleted the arviz branch January 1, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants