Skip to content

Conversation

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 88.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.88%. Comparing base (c868a84) to head (ef13c34).

Files with missing lines Patch % Lines
pymc/logprob/arithmetic.py 88.33% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8074      +/-   ##
==========================================
- Coverage   90.89%   90.88%   -0.01%     
==========================================
  Files         123      123              
  Lines       19489    19547      +58     
==========================================
+ Hits        17714    17765      +51     
- Misses       1775     1782       +7     
Files with missing lines Coverage Δ
pymc/logprob/arithmetic.py 91.86% <88.33%> (-8.14%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eclipse1605
Copy link
Contributor Author

@ricardoV94 do we remove the failing test or change the name and make the replacement

res = conditional_logp({y_rv: y})
assert y in res

@ricardoV94
Copy link
Member

@ricardoV94 do we remove the failing test or change the name and make the replacement

res = conditional_logp({y_rv: y})
assert y in res

change it to use other RVs that don't have closed form solution

@eclipse1605
Copy link
Contributor Author

eclipse1605 commented Jan 27, 2026

change it to use other RVs that don't have closed form solution

sure ill do

x_rv1 = pt.random.exponential(name="x_rv1")
x_rv2 = pt.random.exponential(name="x_rv2")

@eclipse1605
Copy link
Contributor Author

@ricardoV94 the failing test if flaky right?

@ricardoV94
Copy link
Member

change it to use other RVs that don't have closed form solution

sure ill do

x_rv1 = pt.random.exponential(name="x_rv1")
x_rv2 = pt.random.exponential(name="x_rv2")

that's equivalent to a gamma, use different scales in each rv, to be more future proof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support measurable rewrites for pt.add and pt.sub of NormalRVs

2 participants