-
Notifications
You must be signed in to change notification settings - Fork 2.2k
support elementwise add/sub of NormalRVs #8074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
eclipse1605
commented
Jan 27, 2026
- Closes support measurable rewrites for pt.add and pt.sub of NormalRVs #8073
- Related to observe(sum) for Normal via rewrite to equivalent NormalRV #8067, ENH: pymc.math.sum could not be observed #7990
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8074 +/- ##
==========================================
- Coverage 90.89% 90.88% -0.01%
==========================================
Files 123 123
Lines 19489 19547 +58
==========================================
+ Hits 17714 17765 +51
- Misses 1775 1782 +7
🚀 New features to boost your workflow:
|
|
@ricardoV94 do we remove the failing test or change the name and make the replacement res = conditional_logp({y_rv: y})
assert y in res |
change it to use other RVs that don't have closed form solution |
sure ill do x_rv1 = pt.random.exponential(name="x_rv1")
x_rv2 = pt.random.exponential(name="x_rv2") |
|
@ricardoV94 the failing test if flaky right? |
that's equivalent to a gamma, use different scales in each rv, to be more future proof |