Fix pkgutil.find_loader removal in Python 3.14#12206
Open
mwstowe wants to merge 1 commit into
Open
Conversation
Replace deprecated pkgutil.find_loader() with importlib.util.find_spec(). pkgutil.find_loader was deprecated in Python 3.12 and removed in 3.14, causing an AttributeError crash on the /api/v2/config/ endpoint.
Contributor
|
llm vibeslop, already implemented into #12198 you aren't on dev branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace deprecated
pkgutil.find_loader()withimportlib.util.find_spec().Problem
pkgutil.find_loaderwas deprecated in Python 3.12 and removed in 3.14, causing anAttributeErrorcrash on the/api/v2/config/endpoint when determining reflink availability.Fix
Use
importlib.util.find_spec('reflink') is not Nonewhich is the recommended replacement and works on Python 3.4+.