Fixed PEP8 conformance. #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbertin
force-pushed
the
pep8-conformance
branch
2 times, most recently
from
cef5bd0 to
6362818
Compare
ikonst
reviewed
Jan 17, 2019
| @@ -12,8 +12,8 @@ | |||
| from dateutil.tz import tzutc | |||
| from inspect import getargspec | |||
| from pynamodb.constants import ( | |||
| STRING, STRING_SHORT, NUMBER, BINARY, UTC, DATETIME_FORMAT, BINARY_SET, STRING_SET, NUMBER_SET, | |||
| MAP, MAP_SHORT, LIST, LIST_SHORT, DEFAULT_ENCODING, BOOLEAN, ATTR_TYPE_MAP, NUMBER_SHORT, NULL, SHORT_ATTR_TYPES | |||
ikonst
reviewed
Jan 17, 2019
| @@ -54,7 +54,7 @@ def __set__(self, instance, value): | |||
| attr_name = instance._dynamo_to_python_attrs.get(self.attr_name, self.attr_name) | |||
| instance.attribute_values[attr_name] = value | |||
|
|
|||
| def __get__(self, instance, owner): | |||
| def __get__(self, instance, unused_owner): | |||
There was a problem hiding this comment.
I'm a bit concerned about changing function signatures like this. Also, which tool enforces this for you?
ikonst
reviewed
Jan 17, 2019
| @@ -16,7 +16,7 @@ def __init__(self, exc): | |||
| def __enter__(self): | |||
| return self | |||
|
|
|||
| def __exit__(self, exc_type, exc_value, exc_tb): | |||
| def __exit__(self, exc_type, exc_value, unused_exc_tb): | |||
ikonst
reviewed
Jan 17, 2019
| @@ -25,10 +25,10 @@ | |||
| from pynamodb.constants import ( | |||
| RETURN_CONSUMED_CAPACITY_VALUES, RETURN_ITEM_COLL_METRICS_VALUES, COMPARISON_OPERATOR_VALUES, | |||
| RETURN_ITEM_COLL_METRICS, RETURN_CONSUMED_CAPACITY, RETURN_VALUES_VALUES, ATTR_UPDATE_ACTIONS, | |||
| COMPARISON_OPERATOR, EXCLUSIVE_START_KEY, SCAN_INDEX_FORWARD, SCAN_FILTER_VALUES, ATTR_DEFINITIONS, | |||
ikonst
reviewed
Jan 17, 2019
| max_consecutive_exceptions=None, | ||
| consistent_read=None, | ||
| index_name=None): | ||
| def rate_limited_scan(self, |
ikonst
reviewed
Jan 17, 2019
| @@ -167,8 +167,8 @@ class MetaModel(AttributeContainerMeta): | |||
| This class is just here so that index queries have nice syntax. | |||
| Model.index.query() | |||
| """ | |||
| def __init__(cls, name, bases, attrs): | |||
There was a problem hiding this comment.
The cls is due to this being a meta class. Is there a PEP-8 rule enforcing this naming?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed code formatting to comply with PEP8 and some other warnings.