Streamline Attribute.__get__ type stubs #578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikonst
commented
Jan 3, 2019
| def is_type_safe(self, key: Any, value: Any) -> bool: ... | ||
| def validate(self) -> bool: ... | ||
|
|
||
| class ListAttribute(Generic[_T], Attribute[List[_T]]): | ||
| class ListAttribute(Generic[_MT], Attribute[List[_MT]]): |
There was a problem hiding this comment.
ListAttribute's of argument is restricted to MapAttribute-based types.
There was a problem hiding this comment.
oops, that's true only if of is not None, otherwise every element of ListAttribute can be either a number, a string, a MapAttribute, etc. but we cannot really express it in type stubs alone :(
|
cc @garrettheel |
garrettheel
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use the fact that
Attribute[_T]is a generic class to DRY__get__.