Minimal changes to access remote snapshots#26
Draft
jchelly wants to merge 3 commits intopynbody:mainfrom
Draft
Conversation
Contributor
Author
|
This can be tried out in a new virtual env with which seems to work on Cosma and on Windows (I don't have any proper tests for these changes yet.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies topsy to read particle data using the RemoteSwiftSnap class from pynbody/pynbody#924 .
I've put a SWIFT example snapshot on the server for testing. E.g.
If the server flag is present then the filename is taken to be a location on the server.
I'll make this a draft pull request for now in case it's affected by changes to the pynbody pull request.