Skip to content

rtt_cmd: add option to disable local echo #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unsanded wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

rtt_cmd: add option to disable local echo #1924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pyocd/subcommands/rtt_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ def get_args(cls) -> List[argparse.ArgumentParser]:
help="Down channel ID.")
rtt_options.add_argument("-d", "--log-file", type=str, default=None,
help="Log file name. When specified, logging mode is enabled.")
rtt_options.add_argument("--echo", action=argparse.BooleanOptionalAction, default=True,
help="Echo locally typed characters. By default echo is on.")

return [cls.CommonOptions.COMMON, cls.CommonOptions.CONNECT, rtt_parser]

Expand Down Expand Up @@ -191,8 +193,9 @@ def viewer_loop(self, up_chan, down_chan, kb):

if ord(c) == 27: # process ESC
break
elif c.isprintable() or c == '\n':
print(c, end="", flush=True)
if self._args.echo:
if c.isprintable() or c == '\n':
print(c, end="", flush=True)

# add char to buffer
cmd += c.encode("utf-8")
Expand Down
Loading