Drop all SciPy fixes from pyodide-build - #395
Open
agriyakhetarpal wants to merge 1 commit into
Open
Conversation
agriyakhetarpal
added
do not merge
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all SciPy fixes from our code, so that we do not interfere with SciPy builds at all.
This PR is not ready to be merged right now. However, I've been using a neutered rendition of this to aid my work on pyodide/pyodide-recipes#604. I raised
RuntimeErrors in these places to ensure that these fixes and f2c hacks are not called when building SciPy. I am going to replace that with this PR, so that we have no code to call at all.Note that f2c-related fixes are also used outside the SciPy recipe, so they are kept.
We should be able to merge this PR once I upstream my work (very soon! edit: done, see pyodide/pyodide-recipes#609).