Skip to content

feat: detect architecture/libc from wheel #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2025
Merged

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Feb 23, 2025

towards #512

Getting the musllinux version for cross-repaired musl wheels is not handled yet here.

fixes #390: the default platform is changed from highest policy to auto which represents the highest compatible platform tag for any given wheel.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 93.37979% with 19 lines in your changes missing coverage. Please review.

Project coverage is 92.68%. Comparing base (38ac457) to head (3a2dc4f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/auditwheel/wheel_abi.py 83.63% 6 Missing and 3 partials ⚠️
src/auditwheel/lddtree.py 74.07% 4 Missing and 3 partials ⚠️
src/auditwheel/main_repair.py 96.00% 1 Missing and 1 partial ⚠️
src/auditwheel/main_show.py 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   92.24%   92.68%   +0.44%     
==========================================
  Files          22       21       -1     
  Lines        1573     1737     +164     
  Branches      286      326      +40     
==========================================
+ Hits         1451     1610     +159     
- Misses         74       77       +3     
- Partials       48       50       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mayeut mayeut marked this pull request as ready for review February 25, 2025 06:48
@mayeut mayeut requested a review from lkollar March 1, 2025 06:08
@mayeut

This comment was marked as outdated.

@mayeut mayeut force-pushed the drop-arch branch 2 times, most recently from 003423f to 1d319cf Compare March 8, 2025 11:19
@auvipy auvipy self-requested a review March 20, 2025 16:07
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@mayeut mayeut merged commit fb071da into pypa:main Mar 29, 2025
14 checks passed
@mayeut mayeut deleted the drop-arch branch March 29, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically repair to the most compatible/oldest platform tag
2 participants