Skip to content

Conversation

@mayeut
Copy link
Member

@mayeut mayeut commented Dec 28, 2025

The default behaviour still returns an error but this can now be overridden.

close #438

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new --allow-pure-python-wheel flag that allows auditwheel to process pure Python wheels (wheels with no platform-specific binaries) without returning an error. By default, auditwheel still returns an error for pure Python wheels to maintain backward compatibility, but users can now opt-in to allow them.

Key changes:

  • Added --allow-pure-python-wheel command-line flag to both show and repair commands
  • For repair mode with the flag enabled, pure Python wheels are copied to the output directory unchanged
  • Added comprehensive test coverage for the new functionality including edge cases

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
tests/integration/test_nonplatform_wheel.py Added new test test_non_platform_wheel_pure_allow to verify pure Python wheel handling with the new flag; parametrized existing tests to ensure the flag doesn't affect non-pure-Python error cases
src/auditwheel/main_show.py Added --allow-pure-python-wheel argument; tracks whether a wheel is pure Python and returns success (0) when the flag is set for pure Python wheels
src/auditwheel/main_repair.py Added --allow-pure-python-wheel argument; copies pure Python wheels to the output directory unchanged when the flag is set, using samefile() check to avoid unnecessary copying

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.24%. Comparing base (430e67f) to head (4a6f571).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
+ Coverage   95.20%   95.24%   +0.03%     
==========================================
  Files          22       22              
  Lines        1815     1829      +14     
  Branches      340      343       +3     
==========================================
+ Hits         1728     1742      +14     
  Misses         48       48              
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mayeut mayeut requested a review from lkollar December 28, 2025 10:37
@mayeut mayeut merged commit 4490469 into pypa:main Dec 29, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants