ci: try using tox-uv #738
Open
ci: try using tox-uv #738
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/ci/ub
branch
2 times, most recently
from
b03b9bd to
e8bb33c
Compare
henryiii
force-pushed
the
henryiii/ci/ub
branch
from
e8bb33c to
1c02b22
Compare
|
Perhaps we could try using https://github.com/tox-dev/tox-gh? |
henryiii
force-pushed
the
henryiii/ci/ub
branch
from
1c02b22 to
e7856f3
Compare
|
The hope here was to make the tests a bit faster; tox-gh might shorten the config, but wouldn't be faster (AFAIK). I don't understand why one test now uninstalls setuptools when it didn't before when running with tox-uv. |
Signed-off-by: Henry Schreiner <[email protected]>
layday
approved these changes
Mar 9, 2025
layday
reviewed
Mar 9, 2025
| @@ -68,10 +71,15 @@ jobs: | |||
| - name: Setup python for tox | |||
| uses: actions/setup-python@v5 | |||
| with: | |||
| python-version: 3.9 | |||
| python-version: 3.12 | |||
There was a problem hiding this comment.
Suggested change
| python-version: 3.12 | |
| python-version: "3.12" |
There was a problem hiding this comment.
Actually, I think this isn't needed anymore, since I changed tox to be installed via uv tool. Let's check that first.
|
Interesting, the three failures are: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up CI a little bit. Closes #858.