fix(schema): default is fine for pyodide too - #2951
Open
henryiii wants to merge 6 commits into
Open
Conversation
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
agriyakhetarpal
approved these changes
Jul 27, 2026
Contributor
Author
|
This should work too, but doesn't: [[tool.cibuildwheel.overrides]]
select = ["*pyodide*"]
build-frontend = "pyodide-build" |
Override properties reference the global build-frontend schema, which does not list pyodide-build. An override that selects the pyodide platform could not set the frontend, although cibuildwheel accepts it at runtime. The overrides schema now has its own build-frontend definition that adds the pyodide-build forms. The per-OS tables stay unchanged, so pyodide-build is still rejected for the other platforms. Assisted-by: ClaudeCode:claude-opus-5
Setting build-frontend to pyodide-build is not an error at the top level, as a configuration can build for pyodide only. Adding it to the global build-frontend definition also covers the overrides and the platform tables, which reference it, so the special case for overrides is removed. Assisted-by: ClaudeCode:claude-opus-5
henryiii
marked this pull request as draft
July 27, 2026 04:24
The platform tables referenced the global build-frontend definition, which now includes pyodide-build. Each table gets a filtered copy instead: the pyodide table keeps only pyodide-build, and the other platforms share a new build-frontend-no-pyodide definition, which drops it. Assisted-by: ClaudeCode:claude-opus-5
The description was one level too high, so it became a stray key next to the definitions instead of a part of "enable". Assisted-by: ClaudeCode:claude-opus-5
The pyodide and non-pyodide variants were made by filtering a copy of the global schema, which had to recover each frontend name from its regex. A function that makes the schema from a list of names replaces the filter and the YAML block. The generated schema does not change. Assisted-by: ClaudeCode:claude-opus-5
henryiii
marked this pull request as ready for review
July 27, 2026 04:52
Contributor
Author
|
Okay, should be more accurate now. "pyodide-build" is accepted at top level, in overrides, and in the "pyodide" platform, but not other platforms. Kept it fairly clean, I think. Also fixes a dangling description that Claude noticed while working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema claims pyodide-build is required, but default is fine too.
Also adding
.claude, so users can symlink.claude/skillsto.agent/skills.