fix: survive short network outages when downloading - #2953
Open
henryiii wants to merge 3 commits into
Open
Conversation
The retry used a flat 3 second wait over 3 attempts, which covers only about 6 seconds of downtime. A CI runner lost DNS for approximately a minute and the PyPy download failed. Wait 3, 6, 12, 24, then 48 seconds over 6 attempts. Assisted-by: ClaudeCode:claude-opus-5
uv stops after 3 retries, which was too few when a runner lost DNS for approximately a minute during a test run. Assisted-by: ClaudeCode:claude-opus-5
A bad URL will not fix itself, and the longer backoff made the wait before the report about 93 seconds. Report 4xx responses at once, and keep retrying 5xx. Assisted-by: ClaudeCode:claude-opus-5
henryiii
force-pushed
the
fix/network-retry-backoff
branch
from
July 27, 2026 16:18
57a7c5e to
e3a465a
Compare
henryiii
changed the title
henryiii
changed the title
agriyakhetarpal
approved these changes
Jul 30, 2026
agriyakhetarpal
left a comment
agriyakhetarpal
left a comment
Member
There was a problem hiding this comment.
I hope that these issues don't persist on the runners' side, but having our own exponential backoff makes sense to me, especially since it makes our and our users' lives easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
A CI runner lost DNS for approximately a minute during a test run, which failed two macOS Intel jobs. Neither layer of retry was long enough to survive it.
download()waited a flat 3 seconds over 3 attempts, so it covered only about 6 seconds of downtime. It now waits 3, 6, 12, 24, then 48 seconds over 6 attempts. This helps users on unreliable networks, not only CI. The PyPy download was the one that failed.UV_HTTP_RETRIESis now set to 6 for the test workflow.