Only import modules in distutils/command/__init__.py if type checking#352
Closed
abravalheri wants to merge 1 commit intopypa:mainfrom
Closed
Only import modules in distutils/command/__init__.py if type checking#352abravalheri wants to merge 1 commit intopypa:mainfrom
distutils/command/__init__.py if type checking#352abravalheri wants to merge 1 commit intopypa:mainfrom
Conversation
Contributor
Author
|
In 81a8a61 I am trying to add a quick regression test... Not sure if that is that is the best approach (very possibly not). After it is merged we can add the test to the setuptools suite. |
Member
|
As discussed in #345, there's still some uncertainty about the effectiveness of this approach. Let's just do a simple revert and then explore more permanent solutions to the typing system separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #351
Fixpypa/setuptools#4902Fixpypa/setuptools#4906Fixpypa/setuptools#4908Uses the approach described in #345 (comment)