Update the bootstrap guide for tomllib#739
Conversation
cdce8p
left a comment
cdce8p
left a comment
There was a problem hiding this comment.
This seems overly complicated to me. I'd assume that redistributors will need to check how tomli themselves anyway, so I don't see a particular need or improvement with this change.
doc/bootstrap.rst
Outdated
| In Python 3.11 and newer, ``flit_core`` uses the standard library :mod:`tomllib` | ||
| module, meaning that ``flit_core`` has no third-party dependencies. |
There was a problem hiding this comment.
It's vendored for all Python versions, just not used in >=3.11.
|
I think it is worth updating this document, because for Python 3.11+ the bootstrapping story is pretty easy; it's only downstreams that are still on 3.10 or older (and care about avoiding bundling) that need to figure out the dependency cycle one way or another. But we should make sure the wording is clear that I think we can also get rid of the 'as of version 3.6' qualifier now; version 3.6 was more than 3 years ago, so that's just a distraction. |
|
How's this rephrasing? It's a little more verbose but hopefully clearer. A |
Co-authored-by: Thomas Kluyver <takowl@gmail.com>
|
Thanks, that looks fine to me. 👍 |
3 participants
No description provided.