Use twine's built-in Trusted Publishing support #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks @facutuesca! I'll do a full review in a bit. |
woodruffw
reviewed
May 19, 2025
facutuesca
force-pushed
the
ft/twine-trusted-publish
branch
from
dfb8951 to
f2d4b3e
Compare
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the OIDC token exchange logic, replacing it with
twine's built-in support for Trusted Publishing present in version6.1.0.In practice, this just means running
twinewithout setting theTWINE_PASSWORDenv variable whenever we detect the Trusted Publishing flow.cc @woodruffw