Skip to content

maint: convert to cached_property and other minor refactors #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

maint: convert to cached_property and other minor refactors #1870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
87df7e2
Fix incorrect type hint on CoreMetadata.version
maresb Dec 27, 2024
4104537
Import cached_property
maresb Dec 14, 2024
0d084fc
Convert first group of ProjectMetadata to cached_property
maresb Dec 14, 2024
6f6f1bd
Migrate straightforward remaining ProjectMetadata properties
maresb Dec 14, 2024
d373038
Migrate several straightforward cases from CoreMetadata to cached_pro…
maresb Dec 14, 2024
3edb90c
Migrate remaining straightforward cases from CoreMetadata to cached_p…
maresb Dec 14, 2024
056ce06
Improve bisect import
maresb Dec 14, 2024
76ba9b9
Improve comments
maresb Dec 14, 2024
2033b12
Add docstrings to hatchling.utils.fs
maresb Dec 14, 2024
11f8879
Rename base_metadata → pkg_info_metadata
maresb Dec 14, 2024
11dbc7a
Update HatchVersionConfig with cached_property
maresb Dec 14, 2024
82131f2
Add a few docstrings
maresb Dec 25, 2024
4f121fa
Slightly simplify CLI version logic
maresb Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions backend/src/hatchling/cli/version/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,12 @@ def version_impl(
plugin_manager = PluginManager()
metadata = ProjectMetadata(root, plugin_manager)

if 'version' in metadata.config.get('project', {}):
static_version = metadata.core.version
if static_version is not None:
if desired_version:
app.abort('Cannot set version when it is statically defined by the `project.version` field')
else:
app.display(metadata.core.version)
app.display(static_version)
return

source = metadata.hatch.version.source
Expand Down
Loading
Loading