chore: List extra-dependencies as regular deps in env show --json#2018
Open
psyclaudeZ wants to merge 1 commit intopypa:masterfrom
Open
chore: List extra-dependencies as regular deps in env show --json#2018psyclaudeZ wants to merge 1 commit intopypa:masterfrom
extra-dependencies as regular deps in env show --json#2018psyclaudeZ wants to merge 1 commit intopypa:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extra-dependenciesare listed in the dependencies column inenv showthanks to #377 . However, it's not the case for when--jsonis present and they're still listed asextra-dependencies. I personally feel it's slightly more intuitive to keep them consistent plus it hides implementation details sinceextra-is just syntactic sugar per se.I didn't file an issue since it's pretty straightforward to patch up. Also I understand that Hyrum's Law might apply to some of the consumers so happy to discuss the trade-offs.
Test Plan
CI.