Clarify Python constraint incompatibility error#2335
Open
danialza wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2181
Summary
requires-pythonconstraint instead of saying it cannot be located.cannot locate Pythonmessage for unknown or unavailable Python versions.Root cause
Compatibility checks use the same final fallback for a missing interpreter and for an interpreter that was intentionally rejected by
requires-python, so the error message could point users in the wrong direction.Checks
PATH="$PWD/.venv/bin:$PATH" .venv/bin/python -m pytest tests/cli/env/test_create.py::test_incompatible_python_constraint tests/cli/env/test_create.py::test_incompatible_single tests/cli/env/test_create.py::test_incompatible_matrix_full tests/cli/env/test_create.py::test_incompatible_matrix_partial tests/cli/run/test_run.py::test_incompatible_missing_python -q.venv/bin/python -m ruff check src/hatch/env/virtual.py tests/cli/env/test_create.py.venv/bin/python -m ruff format --check src/hatch/env/virtual.py tests/cli/env/test_create.py.venv/bin/python -m mypy src/hatch/env/virtual.py.venv/bin/python scripts/validate_history.py