Add utility to select things with compatible tags#1110
Open
Add utility to select things with compatible tags#1110
Conversation
Member
Author
|
@brettcannon how do you like this one? |
08ce96f to
8a3a7ec
Compare
8a3a7ec to
2cf7143
Compare
Member
Author
|
I made it return an iterator to allow for possible future optimizations. So obtaining the best compatible wheel looks like this: >>> filenames = ["foo-1.0-py3-none-any.whl", "foo-1.0-py2-none-any.whl"]
>>> selector = create_compatible_tags_selector(tags.sys_tags())
>>> next(selector([
... (filename, parse_wheel_filename(filename)[-1]) for filename in filenames
... ]), None)
"foo-1.0-py3-none-any.whl" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coming from #1092 (comment), this PR proposes a utility to select things that best match an ordered list of tags.
It works like this, for instance, to select compatible wheel filenames: