PEP 440 handling of prereleases for Specifier.contains, SpecifierSet.contains, and SepcifierSet.filter
#897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw
force-pushed
the
pep-440-handling-of-pre-releases
branch
from
2519ee8 to
dd2c085
Compare
henryiii
force-pushed
the
pep-440-handling-of-pre-releases
branch
from
e1352dc to
8b051ec
Compare
henryiii
force-pushed
the
pep-440-handling-of-pre-releases
branch
from
8b051ec to
b44bfdb
Compare
Signed-off-by: Henry Schreiner <[email protected]>
notatallshaw
commented
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #854
Fixes #895
Fixes #856
Builds on top of and, if accepted, supersedes #872
The goal of this is to have packaging specifier methods consistently follow the recommendation of PEP 440 and the specification:
Specifically this PR fixes
Specifier.contains,SpecifierSet.contains, andSepcifierSet.filter, but does not change the behavior ofSepcifier.filterwhich already correctly complies with the above points.This PR moves all the logic of implementing this into the
filtermethods and then makes thecontainsmethods fairly simple wrappers around thefiltermethods.This PR adds many tests, but could probably do with thousands more.