Fix subprocess stream decoding for split UTF-8 output - #1074
Open
0xTaoZ wants to merge 1 commit into
Open
Conversation
0xTaoZ
force-pushed
the
0xTaoZ/fix-subprocess-stream-decoding
branch
from
July 2, 2026 12:40
58ed4d7 to
e689b73
Compare
0xTaoZ
marked this pull request as ready for review
July 2, 2026 12:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #574.
This updates the subprocess wrapper to drain stdout and stderr concurrently while decoding progress stdout with an incremental UTF-8 decoder. That prevents split multibyte sequences from being surfaced as replacement characters while preserving the existing progress update behavior.
Tests added:
log_stdout=TrueLocal checks:
.venv/bin/python -m pytest test/test_subprocess.py -q.venv/bin/python -m ruff check pip_audit/_subprocess.py test/test_subprocess.py.venv/bin/python -m mypy pip_audit/_subprocess.py.venv/bin/python -m ruff format --check pip_audit/_subprocess.py test/test_subprocess.pygit diff --check