Skip to content

Stop falling back to setup.py install by default #11013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pradyunsg
Copy link
Member

Toward #8368

@sbidoul
Copy link
Member

sbidoul commented Apr 7, 2022

@pradyunsg before doing this don't we need to disentangle --no-binary first ? IOW finish #9422, which I still hope to find the time to do someday.

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 7, 2022
@pradyunsg
Copy link
Member Author

Yes we do.

I opened this as a draft, to get a better idea of how complicated this removal would be in terms of the test suite (by running CI on this change) -- given that the code change is fairly "cheap". :)

@pradyunsg
Copy link
Member Author

FAILED tests/functional/test_install_index.py::test_find_links_no_doctype - a...
FAILED tests/functional/test_install.py::test_install_wheel_broken - Assertio...
FAILED tests/functional/test_install.py::test_cleanup_after_failed_wheel - As...
FAILED tests/functional/test_install.py::test_install_builds_wheels - Asserti...
FAILED tests/functional/test_install.py::test_install_no_binary_disables_building_wheels

Not too bad. :)

@pradyunsg pradyunsg closed this Apr 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants