Fix direct preference in PipProvider.get_preference
#13244
+52
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw
force-pushed
the
fix-direct-preference
branch
2 times, most recently
from
858f203 to
b3bb515
Compare
|
Merged main and simplified new test construction |
notatallshaw
force-pushed
the
fix-direct-preference
branch
from
6332444 to
8284705
Compare
|
Okay, I've significantly simplified the test construction for this fix, so I've fixed up and rebased the commits, making them easier to review and less likely to create merge conflicts with other updates to this part of the resolver. |
pfmoore
reviewed
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12975
Also see #13164 for real world impact with a reproducible example that is fixed by this PR.
Most of the effort in this PR is extending the unit tests to include testing a requirement with an
ExplicitRequirement, probably there was a simpler way to do this, I intend to keep extending and improving the unit tests in following PRs.