Fix pep668 tests on ubuntu 24.04+ #13603
Closed
+51
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw
added
the
skip news
|
Well, this is annoying, I am able to reproduce the failures locally using a clean Ubuntu environment, my patch fixes the errors locally, but it seems they still fail in CI, I do guard applying the patch, I'm going to apply it unconditionally and see what happens., |
notatallshaw
force-pushed
the
fix-pep668-tests-on-ubuntu-24.04+
branch
from
b3dcc84 to
be28d06
Compare
|
Nope, this patch doesn't work in CI even applied unconditionally, I'm giving up on this for now, I don't have enough knowledge here, so I was mostly trying many random things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #13568
This PR will not enable
ubuntu-latestso to show that these changes working I am going to add a commit one at a time and let CI run:ubuntu-latestand show failuresubuntu-22.04Once this is done I will add a more detailed comment on my approach.