-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Improve pip config set error when PIP_CONFIG_FILE is non-regular #13790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gcomneno
wants to merge
8
commits into
pypa:main
Choose a base branch
from
gcomneno:contrib/issue-11880-config-set-devnull
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−2
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0379832
Improve pip config set error when PIP_CONFIG_FILE is non-regular
gcomneno cc91e30
Improve pip config set error for non-regular PIP_CONFIG_FILE
gcomneno ce6a8d1
Add news fragment for config set error
gcomneno e2530cf
Improve pip config set error for non-regular PIP_CONFIG_FILE
gcomneno 7d0b6fb
Fix end-of-file
gcomneno 7309adf
tests: accept 'not a regular file' error for PIP_CONFIG_FILE
gcomneno ff45176
tests: skip /dev/null PIP_CONFIG_FILE case on Windows
gcomneno 8c09222
tests: use os.devnull for PIP_CONFIG_FILE non-regular case
gcomneno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Improve the error message from ``pip config set`` when ``PIP_CONFIG_FILE`` points to a non-regular file (e.g. ``/dev/null``). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not make the test work on windows using the equivalent windows special file (
NUL)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.python.org/3/library/os.html#os.devnull might be relevant here.