Skip to content

Run python -m pip install . before install CI dependencies#13791

Open
notatallshaw wants to merge 3 commits intopypa:mainfrom
notatallshaw:dog-food-pip-install-in-CI
Open

Run python -m pip install . before install CI dependencies#13791
notatallshaw wants to merge 3 commits intopypa:mainfrom
notatallshaw:dog-food-pip-install-in-CI

Conversation

@notatallshaw
Copy link
Member

@notatallshaw notatallshaw commented Feb 7, 2026

I think it would be a good sanity check to use the development version of pip to install the CI dependencies.

This also allows immediately enabling new pip features in the CI, allowing for dogfooding.

@notatallshaw notatallshaw added the skip news Does not need a NEWS file entry (eg: trivial changes) label Feb 7, 2026
@notatallshaw notatallshaw changed the title Run pip install . before install CI dependencies Run python -m pip install . before install CI dependencies Feb 7, 2026
- uses: actions/setup-python@v6
with:
python-version: "3.x"
- run: python -m pip install .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable. Should we then use python -m pip to install nox too, to be sure we use the same environment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'm only using python -m here as upgrading pip via pip install isn't possible on Windows. I hope there aren't two different Python environments here but it's possible.

Also if pip isn't in the same environment as python -m pip it's possible that nox and python -m nox isn't either, so I've replaced all calls to nox as well.

@ichard26
Copy link
Member

ichard26 commented Feb 7, 2026

This seems fine in theory, but I'm not sure if there's a clear benefit? The test environment itself is managed by nox and we already install development pip in those1. The only change is that nox (and its dependencies) will be installed using development pip.

Footnotes

  1. Furthermore, we actually use a PyPI copy of pip to install test suite dependencies to avoid a buggy local pip preventing the test suite from even running at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news Does not need a NEWS file entry (eg: trivial changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments