Run python -m pip install . before install CI dependencies#13791
Run python -m pip install . before install CI dependencies#13791notatallshaw wants to merge 3 commits intopypa:mainfrom
python -m pip install . before install CI dependencies#13791Conversation
pip install . before install CI dependenciespython -m pip install . before install CI dependencies
| - uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: "3.x" | ||
| - run: python -m pip install . |
There was a problem hiding this comment.
Sounds reasonable. Should we then use python -m pip to install nox too, to be sure we use the same environment?
There was a problem hiding this comment.
Good catch, I'm only using python -m here as upgrading pip via pip install isn't possible on Windows. I hope there aren't two different Python environments here but it's possible.
Also if pip isn't in the same environment as python -m pip it's possible that nox and python -m nox isn't either, so I've replaced all calls to nox as well.
|
This seems fine in theory, but I'm not sure if there's a clear benefit? The test environment itself is managed by nox and we already install development pip in those1. The only change is that nox (and its dependencies) will be installed using development pip. Footnotes
|
I think it would be a good sanity check to use the development version of pip to install the CI dependencies.
This also allows immediately enabling new pip features in the CI, allowing for dogfooding.