Draft
Conversation
ichard26
force-pushed
the
vendoring/26.1p1
branch
from
bce4f46 to
29cb41c
Compare
Member
Author
|
Oh, looks like platformdirs has changed behaviour for the paths we care about. I'll take a look later when I have more time. |
Member
|
Agreed regarding rich. Have they vendored the whole Unicode database multiple times, or something??? Maybe we can patch out the extra files. I don't know if our vendoring mechanism is capable of doing that, but it might be worth looking into. It's already our biggest vendored dependency, and I'm not really keen on it getting worse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a huge fan of Rich adding 10,000 LOC, but that's out of our control I suppose.
Anyway, this pulls in the latest platformdirs fixes which will resolve #13708.