Install headers to UNKNOWN on missing dist name #9719
Conversation
This matches the legacy distutils behavior.
uranusjr
added
skip news
| paths["scripts"] = os.path.join(base, python_xy, "Scripts") | ||
|
|
||
| # Substitute an empty name with "UNKNOWN" for distutils compatibility. | ||
| headers = os.path.join(paths["include"], dist_name or "UNKNOWN") |
There was a problem hiding this comment.
Wait, what?
I thought the new behaviour was "more correct", and it'd be worthwhile to be a little disruptive about it.
There was a problem hiding this comment.
Strictly speaking, there isn’t really a “more correct” behaviour here. This is trying to get a header path for a distribution, and a distribution without a name shouldn’t have a header path in the first place.
In practice, this case is hit when pip tries to get some other paths (e.g. to get the scripts directory) and doesn’t really care about headers. Those calls should ideally be changed to use something that makes more sense instead, but there are a lot of them.
There was a problem hiding this comment.
The warning message about this is not just “a little” disruptive. It’s pretty likely to be shown much too often things and flood over actual issue reports.
|
Hey, congrats, this fails from the other direction: So this is not the correct fix. Back to the drawing board, I guess. |
2 participants
Resolves issue raised in #9617 (comment).
News fragment skipped since the sysconfig migration has not been released yet.