Update urllib3 to 1.26.4 to fix CVE-2021-28363 #9760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
approved these changes
Apr 2, 2021
Member
pradyunsg
left a comment
pradyunsg
left a comment
There was a problem hiding this comment.
Assuming our vendoring job says OK, LGTM!
Contributor
Author
|
That's what I used to make this. It was a smooth and easy job, for which I want to thank you. Vendoring sucks, but at least it's easy now. Kudos! |
Contributor
Author
|
BTW the vendor news category is not documented in the contributing docs, or at least I haven't seen it there. I've assumed it exists and found another file like it. |
Member
|
FWIW, our MacOS CI is basically DOS'd at this point; with 5 workers and way more jobs in the queue, this'll take a while. :) |
Member
Yea, usually we don't expect contributors to be bumping vendored packages in PRs. :P |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.