Cleanup unused dependencies #6386
Merged
+98
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up unused dependencies after upgrading packages by removing entries from the lockfile that are no longer required.
- Added an integration test (tests/integration/test_upgrade_cleanup.py) that verifies the removal of now-unused dependencies.
- Introduced a new helper function (_clean_unused_dependencies) in pipenv/routines/update.py to perform the cleanup.
- Updated the upgrade process to store the original lockfile and remove stale entries post-dependency resolution.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/integration/test_upgrade_cleanup.py | New integration test to verify removal of unused dependencies |
| pipenv/routines/update.py | Added _clean_unused_dependencies and updated upgrade workflow to invoke it |
Files not reviewed (1)
- news/6386.bugfix.rst: Language not supported
Comments suppressed due to low confidence (1)
pipenv/routines/update.py:492
- [nitpick] A shallow copy is used for 'original_lockfile', which might lead to unintended shared references if the inner dictionaries are mutated. Consider using a deep copy to ensure the original lockfile remains unaffected by later modifications.
original_lockfile = { k: v.copy() if isinstance(v, dict) else v for k, v in lockfile.items() }
matteius
force-pushed
the
remove-dead-dependencies
branch
from
4f295f7 to
68cbf59
Compare
oz123
approved these changes
Apr 25, 2025
| import pytest | ||
|
|
||
|
|
||
| @pytest.mark.upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
The issue
Fixes #
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.