Fix platform-specific packages causing resolution errors #6499
+31
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6028
When a package has a
sys_platformor other marker that doesn't match the current platform, skip adding it to the constraint set before resolution. This prevents pip from trying to resolve packages that don't exist for the current platform.Problem
Previously, packages like:
Would cause resolution failures on Linux because the constraint was added to pip's resolver even though the marker didn't match. The error would be:
Solution
Now, packages with non-matching markers are:
This allows cross-platform Pipfiles to work correctly - packages that don't apply to the current platform are simply skipped during resolution rather than causing errors.
Changes
pipenv/utils/resolver.py: Check marker evaluation before adding to constraintstests/integration/test_lock.py: Add test forsys_platformkey syntaxTesting
Added a new test
test_resolve_skip_unmatched_sys_platformthat verifies packages with non-matchingsys_platformmarkers are properly skipped during resolution.Pull Request opened by Augment Code with guidance from the PR author