completions: only complete --options
when a leading -
has been entered
#1638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.d/
(if the patch affects the end users)Summary of changes
pipx uses argcomplete for generating shell completions. By default, argcomplete shows
--option
completions even if no leading-
has been entered.I consider this unusual and it doesn't look cleanly. Other autocompletion engines I know behave differently.
Therefore, I propose to set the
always_complete_options=False
parameter, which shows--options
only when a leading-
has already been entered.Feel free to reject if you like the current behavior more, but I thought I will propose the change since the configuration parameter might have been unknown.
Test plan
Before, subcommands and options are intermixed:

After this change, it is more clean and conforms to the usual behavior:

