Skip to content

Fix find_distributions with non-empty context#212

Merged
takluyver merged 3 commits intopypa:mainfrom
kulikjak:fix-find_distributions
Feb 18, 2026
Merged

Fix find_distributions with non-empty context#212
takluyver merged 3 commits intopypa:mainfrom
kulikjak:fix-find_distributions

Conversation

@kulikjak
Copy link
Contributor

@kulikjak kulikjak commented Apr 10, 2025

find_distributions now honors name parameter from the original context.

Closes #211.

@pradyunsg
Copy link
Member

Would it be possible to add a test for this, to help ensure we don't regress on this behaviour in the future?

@kulikjak
Copy link
Contributor Author

kulikjak commented Apr 16, 2025

Sure, I added a new test (and found a problem in existing one - there was a typo in _test_bootstrap-0.0.1.dist-info).

I didn't have much time to look into it up until today, so it took a little longer; sorry about that.

@kulikjak
Copy link
Contributor Author

Small update: I now tested the patched version with build of ~120 different Python packages and everything seems to work as expected.

@davidt
Copy link

davidt commented Feb 2, 2026

Is there any ETA on this? I'm hitting this with the build of one of our packages, and the proposed fix works for me.

@takluyver takluyver force-pushed the fix-find_distributions branch from e76bdc6 to 38cb960 Compare February 18, 2026 15:29
@takluyver takluyver added this to the 1.3 milestone Feb 18, 2026
@takluyver
Copy link
Member

I'll merge this, but I'd like to sort out the questions about warnings (#157) before making a release, to avoid making anything worse.

@takluyver takluyver merged commit 3de7fad into pypa:main Feb 18, 2026
21 checks passed
@takluyver
Copy link
Member

Thanks @kulikjak !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with new find_distributions and incorrect metadata

5 participants

Comments