Conversation
This was referenced May 31, 2025
b4f74f7 to
ec46ffa
Compare
2 tasks
0171a76 to
6df1385
Compare
c05dc31 to
4ea7ec0
Compare
4ea7ec0 to
558c92f
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Step 6.4 of #2345 (comment)
Once https://peps.python.org/pep-0728/ lands, this can likely be simplified by exposing and combining a
TypedDictfrom_distutilsto use as an annotation for**attrs. I don't think we need to wait for it, implementation can be simplified later, I'm just keeping track here:Pull Request Checklist
newsfragments/.(See documentation for details)