Open
Conversation
This reverts commit 8ba2f38. pkg_resources is too widely used to be removed without serious, community-wide discussion and a larger. Future changes will add notes indicating that is frozen and should not be relied upon for future users. Signed-off-by: Stephen Finucane <stephen@that.guru>
Contributor
|
From my pov the approach discussed in #863 (comment) is more promising, but it would be nice to hear from the other maintaienrs. |
This reverts commit 25fd499.
Signed-off-by: Stephen Finucane <stephen@that.guru>
This module is frozen. We should not be applying new ruff checks on same. Signed-off-by: Stephen Finucane <stephen@that.guru>
stephenfin
force-pushed
the
issue-5174
branch
from
85e0c27 to
2597451
Compare
Contributor
Author
Thanks, @abravalheri 🙏 Probably best to keep the discussion on the two issues so I've responded there. |
Contributor
Author
|
The two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
As discussed in #5174, restore the
pkg_resourcespackage in setuptools. The removal warning is not restored and documentation for same is left indoc/deprecated. Additional documentation is provided to clarify that this module is frozen and no new PRs of any kind will be accepted. To this effect, ruff checks are also disabled for this module to prevent fixes being needed for future checks.Closes #5174
Pull Request Checklist
newsfragments/.(See documentation for details)