Skip to content

Commit

Permalink
packaging: also lower musllinux tag to 1_1
Browse files Browse the repository at this point in the history
We don't know the exact lower bound, so better be too permissive than
restrictive.

Ideally, pip should also allow to override libc version tags, but it's
not obvious if/how this is supported.
  • Loading branch information
mara004 committed Jun 28, 2023
1 parent 343efeb commit 8364457
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions setupsrc/pypdfium2_setup/packaging_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,9 @@ def get_wheel_tag(pl_name):
elif pl_name == PlatformNames.linux_arm32:
return "manylinux_2_17_armv7l"
elif pl_name == PlatformNames.linux_musl_x64:
return "musllinux_1_2_x86_64"
return "musllinux_1_1_x86_64"
elif pl_name == PlatformNames.linux_musl_x86:
return "musllinux_1_2_i686"
return "musllinux_1_1_i686"
elif pl_name == PlatformNames.windows_x64:
return "win_amd64"
elif pl_name == PlatformNames.windows_arm64:
Expand Down
4 changes: 2 additions & 2 deletions tests_old/test_setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ def all_platnames():
(PlatformNames.linux_x86, "manylinux_2_17_i686"),
(PlatformNames.linux_arm64, "manylinux_2_17_aarch64"),
(PlatformNames.linux_arm32, "manylinux_2_17_armv7l"),
(PlatformNames.linux_musl_x64, "musllinux_1_2_x86_64"),
(PlatformNames.linux_musl_x86, "musllinux_1_2_i686"),
(PlatformNames.linux_musl_x64, "musllinux_1_1_x86_64"),
(PlatformNames.linux_musl_x86, "musllinux_1_1_i686"),
(PlatformNames.darwin_x64, "macosx_10_13_x86_64"),
(PlatformNames.darwin_arm64, "macosx_11_0_arm64"),
(PlatformNames.windows_x64, "win_amd64"),
Expand Down

0 comments on commit 8364457

Please sign in to comment.