Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major refactor of the
ParSetbase class.Many files are touched but the primary changes are in
pypeit/par/parset.pyandpypeit/par/pypeitpar.py. Branches that include changes to these files will likely have significant conflicts. I apologize for the headaches, and I'm happy to help with merges. Beyond those two files, the refactor is virtually invisible to the rest of the code, only requiring some changes to imports and some auto-generated doc scripts.The main accomplishment of this PR is that it dramatically cleans up and streamlines the construction of
ParSetsubclasses. Instead of defining the parameters based on the combination of the call sequence of the__init__function and the subsequent body of the function, everything is defined as part of a dictionary class attribute calledparameters. This allows the refactoredParSetclass to handle everything except the definition of those parameters and any validation methods. I.e., none of the currentParSetsubclasses require a bespoke__init__function; they all can make do with the base class method.I used AI to help with this, and a script that compared the old and new versions of the
ParSetsubclasses (the parameters, types, options, and descriptions). After the initial refactor, in which I explicitly made both the old and new subclasses identical, I edited all of the descriptions. Most of this was to ensure a fixed line length, but I also edited the content of some.All the unit tests pass, and I'll set the dev-suite going now.