Skip to content

pyproj.crs: add imports to __all__ #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Conversation

adamjstewart
Copy link
Contributor

This PR explicitly exports all classes in pyproj.crs, allowing type checkers like mypy to better use the type hints. Without this change, mypy will complain with an error like:

> mypy --strict foo.py
foo.py:3: error: Module "pyproj.crs" does not explicitly export attribute "CRS"  [attr-defined]

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (6a38287) to head (1262ed6).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
+ Coverage   96.50%   96.56%   +0.06%     
==========================================
  Files          20       20              
  Lines        1830     1833       +3     
==========================================
+ Hits         1766     1770       +4     
+ Misses         64       63       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adamjstewart
Copy link
Contributor Author

@snowman2 can you review?

@snowman2
Copy link
Member

snowman2 commented May 5, 2025

Thanks @adamjstewart 👍

@snowman2 snowman2 added this to the 3.8.0 milestone May 5, 2025
@snowman2 snowman2 added the documentation Docs need updating label May 5, 2025
@snowman2 snowman2 merged commit 1382fec into pyproj4:main May 5, 2025
17 checks passed
@adamjstewart adamjstewart deleted the crs/init branch May 5, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants