-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add util.mkApplication #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up!
I'm not sure I'm totally grok-ing the from
argument to mkApplication
. Is the idea that the derivation we pass to from
will have just the stuff we want (namely the [project.scripts]
) we need, and so that's a convinient way to figure out what to include in the final application, rather than re-parsing a pyproject.toml file to deduce the scripts? If so, that's clever, but it does include other stuff we don't need (as you call out your post).
from
might be a weird name for the parameter? project
/package
/application
might be less weird?
And this is by design. You might want to include things that have no standardised notion in pyproject.toml such as systemd units & man pages.
Yeah I totally agree.
|
de4425d
to
1b197d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. Thanks again =)
db9cf44
to
fc5b811
Compare
This helper takes a virtual environment and a derivation to use as a structure template & outputs a derivation without venv cruft.
fc5b811
to
9d8e2af
Compare
This helper takes a virtual environment and a derivation to use as a structure template & outputs a derivation without venv cruft.
See pyproject-nix/uv2nix#80
cc @jfly