build.hooks.make-venv: Replace symlink to Python interpreter with a binary wrapper #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
force-pushed
the
venv-interpreter-wrapped
branch
3 times, most recently
from
900e2ba to
17c33b7
Compare
…inary wrapper The venv module creates a symlink to the Python interpreter, but this breaks the venv if you're using a symlink pointing to the virtualenv itself. By replacing the Python interpreter symlink with a wrapper it can be properly linked to in another derivation.
adisbladis
force-pushed
the
venv-interpreter-wrapped
branch
from
17c33b7 to
be1c9ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The venv module creates a symlink to the Python interpreter, but this breaks the venv if you're using a symlink pointing to the virtualenv itself.
By replacing the Python interpreter symlink with a wrapper it can be properly linked to in another derivation.
cc @TyberiusPrime